Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Client.Leader() public. #30

Merged
merged 1 commit into from
Aug 27, 2013
Merged

Make Client.Leader() public. #30

merged 1 commit into from
Aug 27, 2013

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Aug 27, 2013

Also add a more comprehensive comment to disconnectBroker().

This is the last piece of #23 that doesn't heavily depend on getting #15 right
first.

@fw42 @burke @sirupsen

Make Client.Leader() public.
d1bbdae 
Also add a more comprehensive comment to disconnectBroker().

This is the last piece of #23 that doesn't heavily depend on getting #15 right
first.
@fw42
Copy link
Contributor

fw42 commented Aug 27, 2013

👍

eapache added a commit that referenced this pull request Aug 27, 2013
@eapache
Merge pull request #30 from Shopify/client_api_2
761894a 
Make Client.Leader() public.
@eapache eapache merged commit 761894a into master Aug 27, 2013
@eapache eapache deleted the client_api_2 branch August 27, 2013 15:25
mimaison added a commit to mimaison/sarama that referenced this pull request Mar 19, 2020
@mimaison
Add DescribeLogDirs to admin client (IBM#30)
e1a02df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eapache @fw42